gotwebd uses sprintf to update index_page_str and page_str if they were negative. While this specific usage is safe, let's drop it. Since the index_page_str and page_str fields are never read from, remove them. This saves two allocations per request too. ok tracey@

ok tracey@

ok tracey@

ok tracey

ok stsp@

- use openat(2) since we've already opened the containing dir - use fstat(2) instead of multiple seeks - don't special case len == 0 ok and improvements by stsp

ok jamsek

- drops the double loop; paginate in one go - avoid lstat + got_path_dir_is_empty for each entry: use dt_type if provided by the underlying filesystem - fixes a memleak: before `continue' we need to call gotweb_free_repo_dir ok stsp

instead of hardcoding d_i - 2 and so expecting only "." and ".." as skipped entries, use t->prev_disp that is the number of repositories traversed until now (both skipped due to the pagination and the ones actually rendered.) ok jamsek

ok stsp@

allows to hide repositories if they have the magic git-daemon-export-ok file ok op@ tracey@ stsp@

otherwise, the webserver might complain: 'upstream sent invalid header: "gotwebd\x20..." while reading response header from upstream' ok stsp@

We can assume that the querystring was initialized when we reach gotweb_render_header. ok tracey@

This adds a new helper function `gotweb_link' that outputs an HTML link with the parameter correctly escaped. ok stsp@

reported by the W3C validator.

due to an error in the order of the arguments to fcgi_printf that I've introduced last time I touched gotweb_render_header the title is now "/" (or SCRIPT_NAME) and one assets (the safari pinned tab svg) is a funny URL :)

keeping GOTWEBD_REPO_CACHESIZE * sizeof(struct cache_repo) inside the struct server makes it too large for imsg on some platforms (linux at least.) Instead, store a pointer and allocate the array when it's received on the child processes. ok stsp@

ok stsp@

ok stsp@

ok stsp@

if strdup fails we fail to free the querystring Found by clang' scan-build.

dead store found by clang' scan-build.

In 95a4a5a1e8d0952ee0d2523dc31df7170d80e0b3 I forgot to fix the links for the favicons and the web manifest.

problem introduced in commit 625e5896fc9ecf87ccfc92ad2a65cd3be58f73c0