Commit Briefs


Stefan Sperling

open temporary files needed for delta application in got_repo_open()

This prepares for callers of got_repo_open() that cannot afford to open files in /tmp, such as gotwebd. In a follow-up change, we could ask such callers to pass in the required amount of open temporary files. One consequence is that got_repo_open() now requires the "cpath" pledge promise. Add the "cpath" promise to affected callers and remove it once the repository has been opened. ok tracey




Stefan Sperling

store deltas in compressed form while packing, both in memory and cache file

This reduces memory and disk space consumption during packing. with tweaks + memleak on error fix from op@ ok op@


Stefan Sperling

inline struct got_object_id in struct got_object_qid

Saves us from doing a malloc/free call for every item on the list. ok op@



Omar Polo

factorize imsg_clear calls after imsg_flush failures

imsg_clear frees and closes resources allocated as part of enqueueing imsgs so it's a no-op after reads. discussed with and ok stsp@


Stefan Sperling

reuse existing deltas when creating pack files

tested by thomas, naddy, and myself



Stefan Sperling

fix file corruption regression in 'got checkout' caused by commit db696021

got-read-pack must rewind its files temporary files before reusing them. Problem reported by naddy ok tracey naddy



Stefan Sperling

fix bogus "object not found" errors when object ID begins with 00

ok thomas_adam


Stefan Sperling

wrap overlong lines


Stefan Sperling

add O_CLOEXEC (close-on-exec) to openat(2) calls

suggested by millert ok thomas_adam


Stefan Sperling

don't scan pack index offsets for large values if pack file is < 2GB

This saves an iteration over the entire h->offsets array when opening a pack index which should not contain large offsets in the first place. ok millert@


Stefan Sperling

handle pack index files which lack a corresponding pack file

ok millert



Christian Weisgerber

switch from SIMPLEQ to equivalent STAILQ macros

The singly-linked tail queue macros were added to OpenBSD 6.9 and are more widely available on other systems. ok stsp


Stefan Sperling

expose got_pack_parse_ref_delta() for library-internal use

This will be needed by a future 'gotadmin listpack' command.


Stefan Sperling

expose got_packidx_get_object_offset() for library-internal use

This will be needed by a future 'gotadmin listpack' command.



Tracey Emery

fix a leaky ibuf. ok stsp



Stefan Sperling

when reading a pack index byte-swap fields at compile-time where possible

suggested by mpi@ ages ago