Commit Briefs

Stefan Sperling

inline struct got_object_id in struct got_object_qid

Saves us from doing a malloc/free call for every item on the list. ok op@


Stefan Sperling

fix typo in comment: navicate -> navigate


Stefan Sperling

pass an already open commit object to the blame callback

ok op@


Stefan Sperling

stop relying on commit cache for good performance of got_object_id_by_path()

Instead of internally opening and closing the same commit object over and over again, require callers to pass an open commit object in. Avoids an inherent dependency on the commit object cache for reasonable performance. ok op@



Tracey Emery

rm unused vars


Christian Weisgerber

const-ify tables

ok thomas_adam millert


Tracey Emery

style



Stefan Sperling

add "e" (close-on-exec) flag to fopen(3) calls

suggested by millert ok thomas_adam


Stefan Sperling

implement 'got diff -c' for diffing commits with optional filtering by path

Need for filtering by path sugggested by kn@ ok naddy@


Christian Weisgerber

indentation fixes


Stefan Sperling

use gmtime_r(3) instead of localtime_r(3) to display time in UTC as intended

Problem noticed by naddy due to failing regress tests at midnight, and then analyzed with additional help from millert. ok naddy




Tracey Emery

fix missed commit found check


Tracey Emery

fix a glaring logic error in navigation for commits, briefs, and tags.

now, we get the proper commit id from the tailq.


Christian Weisgerber

switch from SIMPLEQ to equivalent STAILQ macros

The singly-linked tail queue macros were added to OpenBSD 6.9 and are more widely available on other systems. ok stsp



Stefan Sperling

unveil gmon.out if gotweb is being profiled

ok tracey


Stefan Sperling

check for close(2) error in got_repo_close() and propagate errors up

ok tracey



Josh Rickmar

Fix strftime(3) short buffer checks

strftime(3) returns 0 if the buffer was too short to write the complete string (including NUL) and will never return more than maxsize-1. ok stsp


Stefan Sperling

make fclose(3) failure checks consistent; check 'fclose() == EOF' everywhere

ok millert, naddy