Commit Briefs

Mark Jamsek

got: always fetch remote HEAD except when -b is used

Rather than only fetch HEAD when there are no branches set in got.conf and there is no branch to be inferred from a work tree, or said branches don't exist on the server, always fetch HEAD unless 'got fetch -b branch' is used. ok stsp@

diff | patch | tree

Mark Jamsek

make 'got fetch -b branch' error reporting more helpful

The patch to got-fetch-pack.c was written by stsp with only minor tweaks by me. Regress updated to account for the change in reporting. stsp's original got-fetch-pack.c diff ok op jamsek ok stsp@

diff | patch | tree

Mark Jamsek

special case 'got fetch -b <branch>' to only fetch <branch>

As discussed on irc, this drops the implicit remote HEAD fetch when -b is used. got.1 has been updated to make the new fetch behaviour clear. ok stsp@

diff | patch | tree

Mark Jamsek

got: use intermediate pointers to plug leak on realloc

And save worktree_branch_len for reuse. ok stsp@ and op@

diff | patch | tree

Stefan Sperling

fix interaction of 'got fetch -b', got.conf, and work tree

Without branches in got.conf for a remote, and without -b/-R options, the fallback to HEAD would only work when not invoked in a work tree. With this fix 'got fetch' should behave as described in the man page. The -b option now overrides both got.conf and the fallback to the work tree's branch. And fallback to HEAD works as expected when invoked in a repository. Also, do not strictly require remote repositories to provide a branch from the refs/heads/ namespace. In such cases users should be able to use -R to select something to fetch. ok jamsek

diff | patch | tree

Omar Polo

got_imsg_fetch_ref: use struct instead of buffer for id

ok stsp@

diff | patch | tree

Omar Polo

got_imsg_fetch_have_ref: use struct instead of buffer for id

ok stsp@

diff | patch | tree

Omar Polo

replace malloc+memcpy with strndup. no functional change intended

ok stsp@

diff | patch | tree

Mark Jamsek

got: minor refactor of got_pathlist_free() API

Accept flag parameter to optionally specify which pointers to free. This saves callers looping through the list to free pointers. ok + fix stsp@

diff | patch | tree

Mark Jamsek

fix uninitialised fildes variables in libexec helpers

Reviewed and uncovered as part of the diff in the forthcoming commit (pathlist API refactor). ok stsp@

diff | patch | tree

Omar Polo

always cast ctype' is*() arguments to unsigned char

ok stsp@

diff | patch | tree

Stefan Sperling

make 'got clone -b' work for repositories which lack a HEAD reference

ok op@

diff | patch | tree

Stefan Sperling

avoid looping over SHA1Update() in got-fetch-pack; suggested by millert@

diff | patch | tree

Stefan Sperling

got-fetch-pack: fix wrong memmove length leading to dubious checksum failures

ok millert tracey

diff | patch | tree

Stefan Sperling

remove trailing whitespace; patch by Josiah Frentsos

diff | patch | tree

Omar Polo

fix snprintf error handling

follow the "proper secure idiom" described in the CAVEATS section of printf(3). reminded by tb@ and millert@

diff | patch | tree

Omar Polo

convert two snprintf to strlcpy

"looks good to me" millert@

diff | patch | tree

Stefan Sperling

imsg_add() frees its msg argument on error; avoid double-free in error paths

diff | patch | tree

Stefan Sperling

apply time-based rate-limiting to got-fetch-pack download progress output

diff | patch | tree

Stefan Sperling

plug memory leaks in got-fetch-pack and got-send-pack

ok naddy

diff | patch | tree

Stefan Sperling

let 'got fetch' send all references to the server to avoid redundant downloads

Problem reported by naddy. ok naddy

diff | patch | tree

Stefan Sperling

fix some integers that had a slightly wrong type; patch by Omar Polo

diff | patch | tree

Stefan Sperling

de-duplicate a constant used by both 'got fetch' and 'got send'

Both GOT_FETCH_PKTMAX and GOT_SEND_PKTMAX had the same value. Declare this value as GOT_PKT_MAX in got_lib_pkt.h instead.

diff | patch | tree

Stefan Sperling

move more code used by got-send-pack and got-fetch-pack to a common file

Move functions and data structures which implement Git protocol features required for fetching and sending pack files to new files lib/gitproto.c and lib/got_lib_gitproto.h. This code was duplicated in got-fetch-pack and got-send-pack. No functional change.

diff | patch | tree

Stefan Sperling

move pkt code used by got-fetch-pack and got-send-pack to a common file

The Git protocol uses a simple packet framing format. The got-fetch-pack and got-send-pack programs contained identical copies of functions to support this format. Move related functions to new file lib/pkt.c and link both programs against this common implementation. No functional change.

diff | patch | tree