Commit Briefs

d7b5a0e827 Stefan Sperling

inline struct got_object_id in struct got_object_qid

Saves us from doing a malloc/free call for every item on the list. ok op@


c0df59665d Stefan Sperling

wrap overlong lines


00fe21f262 Stefan Sperling

add "e" (close-on-exec) flag to fopen(3) calls

suggested by millert ok thomas_adam


0e03968138 Stefan Sperling

preverse binary files during updates and merges




4f18c40008 Christian Weisgerber

fix another segfault in edscript()

Same problem as fixed in 90de04bc7f1b85b9c491bcd124f6178fad005de1. ok stsp


90de04bc7f Stefan Sperling

fix a segfault in edscript() introduced by my previous commit

Found by our cherrypick regression tests.


f10244c07f Stefan Sperling

fix merging of files which contain a dot on a line by itself

Annoying bug which we inherited from OpenRCS which inherited it from OpenBSD's diff3 program. ok tracey millert


abc59930d5 Christian Weisgerber

indentation fixes


fdf3c2d387 Stefan Sperling

use Patience diff for merging during cherrypick/backout/histedit/rebase

This has been shown to prevent mis-merges in some cases. It's probably not a final solution. We should look at what Git's "recursive merge" is doing and implement something similar. Keep using Myers during update/unstage. The advantage of Myers is that it produces smaller conflict chunks, and there are no known cases of mis-merges which affect update/unstage.



1fee9f40e2 Stefan Sperling

fix 3-way merge of files which lack a final \n

problem found by jrick ok millert


bc62ede807 Stefan Sperling

use Myers diff instead of Patience diff when merging files with diff3

Myers diff tends to divide files into smaller diff chunks, while Patience diff attemps to maximize the size of diff chunks. Smaller diffs chunks generally result in a more managable presentation of merge conflicts.


56b63ca4ab Stefan Sperling

make fclose(3) failure checks consistent; check 'fclose() == EOF' everywhere

ok millert, naddy





fe621944e8 Stefan Sperling

merge new diff implementation from the git.gameoftrees.org diff.git repository

This new diff implementation was started by Neels Hofmeyr during the u2k20 hackathon and now replaces diffreg.c code lifted from the OpenBSD base system. The integration of this code into Got was done by me. Got now uses the patience diff algorithm by default. The diff.git repository will remain the primary repository for the diff code, which already compiles and runs on other operating systems such as Linux. Any fixes and improvements for files inherited from the diff.git repository should be written against that repository and synced to got.git afterwards.



bb63914a95 Stefan Sperling

make tmp dir location a compile-time setting and change gotweb's tmp dir

We are not sure whether a gotweb package can own /var/www/tmp on OpenBSD. Moving gotweb's tmp dir to /var/www/got/tmp sidesteps that issue.


937e0e5871 Stefan Sperling

fix build on sparc64 (uninitialized variable) (tags/0.18)



d136cfcb98 Stefan Sperling

show original file content in conflict markers