Commit Briefs

4010e238a0 Stefan Sperling

make tog call pledge(2) directly in main() instead of per-command

All of tog's pledges are currently the same, and they must be the same because tog allows switching between available command views at run-time. ok tracey




9970f7fca9 Stefan Sperling

replace dead_view pointer in view_loop() with 'dying' flag in struct tog_view

ok naddy


72a9cb46de Stefan Sperling

tog's view_set_child() never returned an error; simplify accordingly

ok naddy


acdafe9c25 Stefan Sperling

remove redundant "child_focussed" variable from struct tog_view

ok naddy


0bf7f15321 Christian Weisgerber

tog's log view needs to request more commits when the window expands

ok stsp


3e13595003 Christian Weisgerber

pass only the view state to scroll functions that don't need the full view

ok stsp


42a2230c34 Christian Weisgerber

reverse tree_view_visit_subtree() parameters for consistency

ok stsp


d91faf3b4d Christian Weisgerber

trim repo parameter from tree_view_walk_path(), already set by open_tree_view()

ok stsp


d86d3b18bf Christian Weisgerber

trim redundant and used parameters from draw_tree_entries()

ok stsp


4f7c3e5ef9 Christian Weisgerber

trim redundant parameters from draw_blame()

ok stsp


89f1a395ef Christian Weisgerber

trim redundant parameters from draw_file()

ok stsp


8fdc79fef0 Christian Weisgerber

trim redundant and unused parameters from draw_commits() and draw_commit()

ok stsp


a538836306 Christian Weisgerber

trim redundant and unused parameters from run_blame()

ok stsp


ffe3850662 Christian Weisgerber

trim redundant parameters from log_scroll_* and trigger_log_thread functions

Also rename scroll_{up,down} to log_scroll_{up,down}; requested by stsp. ok stsp


694d3271e2 Christian Weisgerber

trim redundant parameters from {ref,tree}_scroll_{up,down} functions

Pass only the view and scroll amount to these functions; remove unused parameters and those that are contained in the view state. ok stsp


34ba691717 Stefan Sperling

fix page-up/down in 'tog ref' view; ok naddy


fa86c4bf0e Stefan Sperling

fix page-down/page-up scrolling in the tog tree view

problem reported by, fixed with lots of help from, and ok naddy



5e9266f9d6 Christian Weisgerber

fix a typo that triggered "munmap: Invalid argument" in got blame on FreeBSD

ok stsp


578133c990 Christian Weisgerber

replace echo with printf, stop option processing with "--" for portability

ok stsp


9a1d514689 Christian Weisgerber

fix entry selection when moving to the parent in tog's tree view

The tree view attempts to keep the scroll position of an already visited parent directory intact. If we start out by viewing a subtree and then move up, the scroll position of the parent isn't actually available since the parent tree was never nagivated by the user. In this case tree_view_walk_path() has to fill in some values. The only parent entry we know about in this case is the one which was traversed to reach the child. The best we can do is to lock the parent's scroll position such that the traversed child entry appears at the top of the list if moving up to the parent's view. If we then navigate down again and return, the parent's scroll position will start to be retained and restored properly. Analysis and draft patch by stsp, initial report and simpler fix by yours truly. ok stsp