Commit Briefs

e45c294c26 Stefan Sperling

avoid printing harmless errors that can occur when tog exits due to Ctrl-C

ok jamsek


f044c8414b Stefan Sperling

fix detection of SIGTERM in tog; this signal was accidentally being ignored

ok jamsek


6a0a1bd407 Omar Polo

sync usage with reality

The -h and -V/--version flags must be given before the command; with those flags the command is actually optional, but don't over-complicate the usage string with these nitpicks. ok/improvements stsp@


38d166d8a3 Stefan Sperling

backout Make & command in tog's log view display "searching..."

The limit feature is more than just a search operation, tog's man page has been updated accordingly.


fd6badaa23 Stefan Sperling

tweak view name display in the help screen for clarity


64ffece483 Stefan Sperling

Make & command in tog's log view display "searching..." while loading commits.

This command acts like a search operation, and the display should reflect that.


12c07a25b6 Stefan Sperling

fix indentation; from jamsek


16a2d4f0fd Stefan Sperling

make exiting tog's help screen easier for new users

ok jamsek


94274a8f75 Mark Jamsek

tog: open help in fullscreen irrespective of view configuration

Prompted by a suggestion from stsp to make the help view distinct rather than follow the default behaviour of established views. Occupying the fullscreen seems to be a somewhat established convention for TUI apps. ok stsp@


34a842a42b Mark Jamsek

drop unconventional got_object_commit_dup() routine

Replace with got_object_commit_retain() to increment commit object reference counter. suggested by and ok stsp@


1681ba873c Mark Jamsek

tog: don't embed utf8 glyphs into tog.c source code

Reported by stsp: Embedded utf8 precludes developers running C locales from browsing the code. Fix was suggested by stsp with hints from the tmux(1) codebase. ok stsp@


eaf2c13e05 Mark Jamsek

tog: refactor search setup into tog_view function pointers

Suggested by stsp. While here, add declarations for new help view routines. ok stsp@


ec2a9698e2 Mark Jamsek

tog: implement runtime help accessible via H,F1 keymaps

Original idea inspired from discussion with tb, tobhe, and stsp at g2k22: display view-specific help, with option to toggle display of full key map reference when {H,F1} is pressed again inside the help view. Includes improvements suggested by stsp. ok stsp@


f83ada346b Mark Jamsek

tog: respect current cursor position during log search

ok op@


568eae9578 Mark Jamsek

tog: add new log view limit feature to filter commits

Use the & key map to enter a pattern with which to limit the displayed commits to those matching the provided pattern; similar to less(1) and mutt's limit feature. Includes various tweaks from op. ok plus fixes from op@


d9787ed86e Omar Polo

make got_commit_graph_iter_next use caller-provided storage for the id

and adjust the callers. discussed with and ok stsp@


0c6ad1bc25 Mark Jamsek

tog: make headline highlight extend the full view width

In splitscreen mode, make the active view headline highlight extend the full width of view->ncols. While here, format the tree view header like the blame view by moving the index to the path line. suggested by and ok stsp@


f0f62654dd Mark Jamsek

tog: extend log view author highlight colour to full field width

ok stsp@


3264c09cde Mark Jamsek

tog: ensure stdin is a tty

This guards against {mis,ab}use such as `tog < /dev/null`. ok plus fix from op@


e15c42decf Omar Polo

plug leak in the commit graph iterator

We fail to release the memory for the nodes. To fix it however, we some consumer of the commit graph iterator need to be corrected: the returned pointer is safe to be used only up until the next iter_next call; save a copy it if it's needed afterwards too. ok stsp@


4924afe127 Mark Jamsek

tog: remove gcc ternary if extension

ok stsp@


827a167b34 Stefan Sperling

Group options in accordance with style(9)

patch by Josiah Frentsos


374f69ddc0 Stefan Sperling

tog: add missing checks for NULL pointers in log view state

ok jamsek


11edf34c28 Mark Jamsek

tog: don't block when processing log view 'G' key map

As per stsp's TODO item, make tog respond to key presses while "loading..." history. Initial testing in src.git appears to work as intended. ok stsp@


df68a56be6 Mark Jamsek

tog: fix delayed tree index update

If a child blame view has been opened, halfdelay() is reset to a 1 second refresh rate, so the index in the header lags behind subtree navigation as we set the index based on the selected tree entry, which isn't updated till that refresh cycle completes. Don't wait for the selected_entry to update; instead, compute the index from the first displayed entry and the currently selected line index. improved by and ok stsp@