Since it appends to the given stailq, the ownership is moved and so don't initialize/reset it at the start and neither on error. The caller has to take care of the contents. (kind of) follow up to 2234939fb4. Based upon an original diff from jamsek; ok jamsek

We need to free the matched object id queue on each pack index iteration--not only when the objects/pack dir modification time has changed--otherwise the ids are leaked when we reinitialise the queue in got_packidx_match_id_str_prefix(). tweaked by + ok op@

tweaked by + ok op@

Needs doas to elevate privileges. ok stsp@

I feel safer by using the explicit size of the table rather than an hypothetical maximum value given by the enum. Mostly because in the past I edited a table and forgot to remove the corresponding enum value. ok stsp@

with input/ok from jamsek, tracey and Kyle Ackerman, thanks!

Found/reported and patch by Kyle Ackerman. ok op@

prodded by stsp and jamsek; ok stsp@

suggested / ok stsp

ok op@

discussed / ok stsp@