Previously, the log view would remember the branch of the work tree in which tog was started, and jump back to that branch upon ^L even if a different branch was requested via -c. ok naddy

Recomputing a diff can take time. Only do it if a different commit is going to be displayed.

This short-cut is not necessary and was buggy: The pointer was not updated even if the main view had changed. Removing this code fixes a problem on FreeBSD where pressing 'q' in a child view caused tog to exit. ok naddy

Original analysis and final tweak by yours truly, all the hard work of fixing the program logic by stsp. ok stsp

ok naddy

All of tog's pledges are currently the same, and they must be the same because tog allows switching between available command views at run-time. ok tracey

ok naddy

ok naddy

ok naddy

ok stsp

ok stsp

ok stsp

ok stsp

ok stsp

ok stsp

ok stsp

ok stsp

ok stsp

Also rename scroll_{up,down} to log_scroll_{up,down}; requested by stsp. ok stsp

Pass only the view and scroll amount to these functions; remove unused parameters and those that are contained in the view state. ok stsp

problem reported by, fixed with lots of help from, and ok naddy

The tree view attempts to keep the scroll position of an already visited parent directory intact. If we start out by viewing a subtree and then move up, the scroll position of the parent isn't actually available since the parent tree was never nagivated by the user. In this case tree_view_walk_path() has to fill in some values. The only parent entry we know about in this case is the one which was traversed to reach the child. The best we can do is to lock the parent's scroll position such that the traversed child entry appears at the top of the list if moving up to the parent's view. If we then navigate down again and return, the parent's scroll position will start to be retained and restored properly. Analysis and draft patch by stsp, initial report and simpler fix by yours truly. ok stsp