Commit Briefs

e3ad2c64b4 Stefan Sperling

fix reference counting of raw objects opened via privsep helpers

Such objects were never closed, resulting in memory and file descriptor leaks.


a32f631eeb Stefan Sperling

visit gotctl folder during make obj, release, and clean


210c2321a3 Stefan Sperling

do not hint at empty temporary diff files in the log message buffer

ok op@


4ba5cca9fc Stefan Sperling

ensure that files are in a state where a diff can be created, before diffing

ok op@


6d15dc69f0 Stefan Sperling

use a global flag instead of a per-file flag to detect staged changes

ok op@


b90054ed55 Stefan Sperling

use mkstemps(3) instead of mkstemp(3) for opening named temporary files

Allows 'got commit' to use a ".diff" suffix for temporary diff files. ok op@


2a47b1e585 Stefan Sperling

provide a diff of changes in a temp file while editing a commit log message

ok landry@



27206177c8 Stefan Sperling

sync dist file list



5753b4a9eb Stefan Sperling

respect resource limit for number of open files when sizing the pack file cache

ok op@


d5996b9efc Landry Breuil

add respect_exportok flag, defaulting to off

allows to hide repositories if they have the magic git-daemon-export-ok file ok op@ tracey@ stsp@


585362fdef Omar Polo

gotd: propagate confpath to children as well

otherwise they end up running with default config which isn't ideal. ok stsp@


4398c738bc Omar Polo

awk ftw! no need to grep, awk can filter lines by itself

ok stsp@


ad8ccd554b Omar Polo

change example to use useradd; ok stsp@


b2e7d31ee0 Landry Breuil

send a newline first if erroring out in plaintext mode

otherwise, the webserver might complain: 'upstream sent invalid header: "gotwebd\x20..." while reading response header from upstream' ok stsp@


21f0772650 Stefan Sperling

require space between commit author name and email, for Git compatibility

Allowing such author fields breaks 'got send' towards Github for affected commits because git-index-pack --strict will error out on the server: $ git index-pack --strict pack-de791fb6a3a1961e44ac5d98d72fd533bf9277c8.pack error: object 5d6bde9eaaf27f41ae8fa7112bb45e489d3c16b9: missingSpaceBeforeEmail: invalid author/committer line - missing space before email fatal: fsck error in packed object problem encountered by landry@ ok op@


15f404b1ce Stefan Sperling

avoid incomplete writes of pack file data in got-send-pack



1c9d898d6c Stefan Sperling

avoid incomplete writes of buffered pack file chunks in gotsh



dd4ea8bd9b Stefan Sperling

got-fetch-pack: fix wrong memmove length leading to dubious checksum failures

ok millert tracey



f5d30fbb42 Omar Polo

gotctl: simplify socket_path handling

ok stsp@


b6ef252eba Omar Polo

remove umask TODO