commit_id is not NULL if got_repo_match_object_id returned successfully. ok stsp@

ok stsp@

ok stsp@

in_repo_path was used only to build a path, it's then assigned to path (which is NULL at that point.) Just asprintf into path. ok stsp@

call got_get_repo_commit only once and avoid leaking the field of repo_commit at each loop iteration. ok stsp@

some code-paths may leak it. ok stsp@

it's still used a bit later, so defer the free'ing at the next loop iteration or at function end.

in case of a failure between when it's allocated and when it's released it might get leaked otherwise. ok and semplification stsp@

ok stsp@

got_get_repo_tags needs some tweaking to how tag_commit is allocated too. ok stsp@

all very unlikely. part of a bigger diff that's ok stsp@

drop: - a tautological s[strlen(s)] == '\0' - a few duplicates checks - a lone if (error) when it's always NULL - an extra NULL check part of a bigger diff that's ok stsp@

ok tracey@

this fixes only the HTML escaping of strings, the urlencode is still missig. while here also plug a memory leak in gotweb_render_branches and drop some needless ternary operators. ok tracey@

instead of fcgi_gen_response which outputs only a fixed strings provide a printf-like fcgi_printf: it greatly simplifies the generation of the HTML pages. While here also (probably) fix some HTML errors: the output was verified with the W3C validator and it's correct (in the sense that the tags are properly closed, there are still some other things the validator complains about.) ok/encouragement baseprime@, ok jamsek Thanks for reading such a boring diff!

spotted by noticing gotwebd crashing on some blame requests. Diff from stsp@ with a fix from tracey@, I'm committing it only because he is short on time. ok stsp@

it was broken in 7ecc454 because now we're emitting tags with multiple `class' attributes (by mistake) and only the first one is used. However, instead of fixing the HTML `class' attribute, use a CSS selector to alternate the background colors. ok tracey@

HTML IDs are meant to be unique across the page. While here fix two small errors in the generated HTML (one missing closing div and one extra.) ok tracey@

there's no need to distinguish between plain text blob and a binary one in the output, just send it chunk by chunk. ok tracey@

ok tracey@