Got Mirror

Commits

Commit:: 118a625d39930284f891ea1285efc17fb3848cae
From:: Mark Jamsek <mark@jamsek.dev>
Date:: Sat Feb 18 07:16:02 2023 UTC

got: further fetch tweaks to prevent unintended fetches Implement stsp's suggestion to only fetch remote's HEAD if the symref refs/remote/*/HEAD exists, and its target no longer matches the remote HEAD. This ensures users tracking a project won't miss a change in HEAD, while also fixing the issue reported by naddy where HEAD was fetched by default even though a specific, potentially less active, branch is cloned, resulting in a repository with more commits than necessary. In addition, unless 'got fetch -b <branch>' is used, the remote HEAD branch will be fetched if branches are not set in got.conf and there is no work tree to ascertain a branch, or said branches are not found on the server. ok stsp@

diff | patch | tree

Commit:: 4bff57b4b66990d6829cb83645d1f1d478ae0cea
From:: Stefan Sperling <stsp@stsp.name>
Date:: Tue Feb 14 17:06:42 2023 UTC

backout got: always fetch remote HEAD except when -b is used As pointed out by naddy, this behaviour is not ideal when users want to limit their repository to a particular branch which will diverge from HEAD over time, such as -stable branches. See https://marc.gameoftrees.org/mail/1676388048.8632_0.html

diff | patch | tree

Commit:: 2a19e2e21a876bbc4ae1999ca08ce4c8f2002158
From:: Mark Jamsek <mark@jamsek.dev>
Date:: Tue Feb 14 12:51:29 2023 UTC

got: always fetch remote HEAD except when -b is used Rather than only fetch HEAD when there are no branches set in got.conf and there is no branch to be inferred from a work tree, or said branches don't exist on the server, always fetch HEAD unless 'got fetch -b branch' is used. ok stsp@

diff | patch | tree

Commit:: f72ce919dd6d6c15679c5174c47912ac55be1e18
From:: Stefan Sperling <stsp@stsp.name>
Via:: Mark Jamsek <mark@jamsek.dev>
Date:: Mon Feb 13 13:43:46 2023 UTC

make 'got fetch -b branch' error reporting more helpful The patch to got-fetch-pack.c was written by stsp with only minor tweaks by me. Regress updated to account for the change in reporting. stsp's original got-fetch-pack.c diff ok op jamsek ok stsp@

diff | patch | tree

Commit:: 0dd7613ce65424868ec86f0623e38eb70d9a9321
From:: Mark Jamsek <mark@jamsek.dev>
Date:: Mon Feb 13 13:20:54 2023 UTC

special case 'got fetch -b <branch>' to only fetch <branch> As discussed on irc, this drops the implicit remote HEAD fetch when -b is used. got.1 has been updated to make the new fetch behaviour clear. ok stsp@

diff | patch | tree

Commit:: ec218e165dfd906f44ad491671127ca4b6979ed0
From:: Mark Jamsek <mark@jamsek.dev>
Date:: Tue Feb 7 13:13:38 2023 UTC

got: use intermediate pointers to plug leak on realloc And save worktree_branch_len for reuse. ok stsp@ and op@

diff | patch | tree

Commit:: 188f8dcf2c1c15bf37859e3b587bc6331fd5a097
From:: Stefan Sperling <stsp@stsp.name>
Date:: Tue Feb 7 12:55:53 2023 UTC

fix interaction of 'got fetch -b', got.conf, and work tree Without branches in got.conf for a remote, and without -b/-R options, the fallback to HEAD would only work when not invoked in a work tree. With this fix 'got fetch' should behave as described in the man page. The -b option now overrides both got.conf and the fallback to the work tree's branch. And fallback to HEAD works as expected when invoked in a repository. Also, do not strictly require remote repositories to provide a branch from the refs/heads/ namespace. In such cases users should be able to use -R to select something to fetch. ok jamsek

diff | patch | tree

Commit:: 0701e66c20d0558f1f7c72d7fb700be6fe376d3f
From:: Omar Polo <op@omarpolo.com>
Date:: Wed Feb 1 13:46:08 2023 UTC

got_imsg_fetch_ref: use struct instead of buffer for id ok stsp@

diff | patch | tree

Commit:: 4b4da3bbc7a791ba0d7d9d369dfe1e7b65f7eed4
From:: Omar Polo <op@omarpolo.com>
Date:: Wed Feb 1 13:46:07 2023 UTC

got_imsg_fetch_have_ref: use struct instead of buffer for id ok stsp@

diff | patch | tree

Commit:: 00b3e9ae14f04a45f1ca7445bade6b41a6e8a1c5
From:: Omar Polo <op@omarpolo.com>
Date:: Wed Jan 11 08:33:41 2023 UTC

replace malloc+memcpy with strndup. no functional change intended ok stsp@

diff | patch | tree

Commit:: d8bacb933720b8819f0c4e76b004775aa1885b9b
From:: Mark Jamsek <mark@jamsek.dev>
Date:: Tue Jan 10 10:47:08 2023 UTC

got: minor refactor of got_pathlist_free() API Accept flag parameter to optionally specify which pointers to free. This saves callers looping through the list to free pointers. ok + fix stsp@

diff | patch | tree

Commit:: 9114dd430297e408815019c3bc1df29ba10a9fb8
From:: Mark Jamsek <mark@jamsek.dev>
Date:: Tue Jan 10 10:47:07 2023 UTC

fix uninitialised fildes variables in libexec helpers Reviewed and uncovered as part of the diff in the forthcoming commit (pathlist API refactor). ok stsp@

diff | patch | tree

Commit:: 99fd9ff4bf6d3bee4a29f13ef4ae81aa36fdd4d5
From:: Omar Polo <op@omarpolo.com>
Date:: Thu Nov 17 11:27:48 2022 UTC

always cast ctype' is*() arguments to unsigned char ok stsp@

diff | patch | tree

Commit:: c9f1ac46710e3ac672c769862ae51b838c3c8e46
From:: Stefan Sperling <stsp@stsp.name>
Date:: Tue Nov 8 19:59:34 2022 UTC

make 'got clone -b' work for repositories which lack a HEAD reference ok op@

diff | patch | tree

Commit:: 74737945d01fa40a64535be8018c8dc44859b524
From:: Stefan Sperling <stsp@stsp.name>
Date:: Sun Oct 30 17:14:37 2022 UTC

avoid looping over SHA1Update() in got-fetch-pack; suggested by millert@

diff | patch | tree

Commit:: dd4ea8bd9bd04c88bb85c1b7f67a7f7b3e43b94e
From:: Stefan Sperling <stsp@stsp.name>
Date:: Sun Oct 30 17:14:37 2022 UTC

got-fetch-pack: fix wrong memmove length leading to dubious checksum failures ok millert tracey

diff | patch | tree

Commit:: 5e91dae4dd43b8024731223110ab18f505f453ac
From:: Josiah Frentsos <jfrent@tilde.team>
Via:: Stefan Sperling <stsp@stsp.name>
Date:: Tue Aug 30 16:02:06 2022 UTC

remove trailing whitespace; patch by Josiah Frentsos

diff | patch | tree

Commit:: 438d0cc30baf8e97fd870f5e620833e0a45401aa
From:: Omar Polo <op@omarpolo.com>
Date:: Tue Aug 16 09:35:18 2022 UTC

fix snprintf error handling follow the "proper secure idiom" described in the CAVEATS section of printf(3). reminded by tb@ and millert@

diff | patch | tree

Commit:: ea8d9c76cc8fdc1dacfcc1cb952769fcd0930b10
From:: Omar Polo <op@omarpolo.com>
Date:: Tue Aug 16 09:35:18 2022 UTC

convert two snprintf to strlcpy "looks good to me" millert@

diff | patch | tree

Commit:: 1453347d2463ce1b2700dd9fa810f30f2a443e5e
From:: Stefan Sperling <stsp@stsp.name>
Date:: Thu May 19 07:14:21 2022 UTC

imsg_add() frees its msg argument on error; avoid double-free in error paths

diff | patch | tree

Commit:: dcb64fea5fbc0fb5f5cd1947bef3b5d09e266a79
From:: Stefan Sperling <stsp@stsp.name>
Date:: Wed Feb 23 12:24:25 2022 UTC

apply time-based rate-limiting to got-fetch-pack download progress output

diff | patch | tree

Commit:: e99d9267c8cc287a60f768d4282c01b9f5f6c975
From:: Stefan Sperling <stsp@stsp.name>
Date:: Thu Oct 7 15:29:27 2021 UTC

plug memory leaks in got-fetch-pack and got-send-pack ok naddy

diff | patch | tree

Commit:: dd088d9503d8e7cebbb30c535d8e4d11556c8d30
From:: Stefan Sperling <stsp@stsp.name>
Date:: Wed Oct 6 19:49:06 2021 UTC

let 'got fetch' send all references to the server to avoid redundant downloads Problem reported by naddy. ok naddy

diff | patch | tree

Commit:: 030daac821622c8495676bc5210fb7784c7ae78f
From:: Stefan Sperling <stsp@stsp.name>
Date:: Sat Sep 25 10:26:13 2021 UTC

fix some integers that had a slightly wrong type; patch by Omar Polo

diff | patch | tree

Commit:: 77d7d3bb1aabafae6c020c8a07a6e9f4f7885c9b
From:: Stefan Sperling <stsp@stsp.name>
Date:: Sun Sep 5 20:39:50 2021 UTC

de-duplicate a constant used by both 'got fetch' and 'got send' Both GOT_FETCH_PKTMAX and GOT_SEND_PKTMAX had the same value. Declare this value as GOT_PKT_MAX in got_lib_pkt.h instead.

diff | patch | tree