Commits
- Commit:
babd9f5d19e75f2db561f5873c7acaf5f56c0480
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got_imsg_raw_delta_request: use struct instead of buffer for id
ok stsp@
- Commit:
265df21f29865b8cc1eb0f0b93b8ca91ff134414
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got_imsg_packed_object: use struct instead of buffer for id
ok stsp@
- Commit:
0a618912c7bba9bfab2be331204824e4bba303c3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid traversing enumerated commits more than once in got-read-pack
Keep track of parent commits that will be processed as part
of looping over the commit queue provided by the main process,
and do not add these commits to the queue again.
Fixes pointless traversal of commits on the queue which will
simply be skipped. The end result is the same either way.
ok tracey
- Commit:
e1380e2807453e7f6feedf4b930146b511620427
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix missing commits in pack files created with packed object enumeration
got-read-pack forgot to send a tree-enumeration-done message to the
main process if the tree of a given commit had already been traversed.
The main process would then not add the corresponding commit to the
pack file, even though it should be added.
Found while using 'got send' towards gotd in order to populate an
empty repository on the server with non-trivial history, where some
commits always ended up missing due to this bug.
ok tracey
- Commit:
24b7de1c04072bf25db2df8acbf93a7ba7bbabfd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid copying reused deltas to delta cache file; copy from pack file instead
ok op@
- Commit:
1c28a36116110db5de40e6edf09887651f3ca37b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
check size before calling mmap(2)
It's only a preparatory step, as checking whether a size_t is less than
SIZE_MAX is moot. In a follow-up commit, however, the `filesize' field
of the struct got_pack will become off_t and these checks will kick in.
This also makes consistent how we guard mmap(2) against empty files.
ok and improvements stsp@
- Commit:
d294b1dcc034776a6df07345f9af90e594409062
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
allow got_object_parse_tree to reuse entries buffer allocations for speed
ok millert@
- Commit:
5e91dae4dd43b8024731223110ab18f505f453ac
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove trailing whitespace; patch by Josiah Frentsos
- Commit:
756050ac401f1e724f0c1fd97af4a9855589c703
- From:
- Omar Polo <op@omarpolo.com>
- Date:
mark got_error_fmt as printf-like and fix the arisen errors
ok stsp@
- Commit:
61af9b215c06bece11deb27d941b390b81e0f8c6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
implement support for commit coloring in got-read-pack for speed
ok op, tracey
- Commit:
89a34d6e53b40dde314248e45b8f3b626fbf85c6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
wrap an overlong line in enumeration_request()
- Commit:
a5e587e014cba0e9dc62ab1817983c89851cbe93
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix a bug in got_privsep_send_object_idlist() exposed by recent changes
The old code did not work correctly if only a single object Id was to
be sent to got-read-pack. Make got-read-pack error out if the list
of commits for object enumeration is empty to catch this problem if
it occurs again.
Found by the send_basic test, which was failing with GOT_TEST_PACK=1
ok tracey
- Commit:
db9b9b1c2b70d98419e70b05e7283b2284bedbec
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
let got-read-pack be explicit about whether it could enumerate all objects
This allows the main process to avoid looping over all object IDs again
in case the pack file used for enumeration is complete.
ok op@
- Commit:
ffe3518f1b3ac78ceeac8b605cb0eec2006bae67
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix wrong arguments to calloc(3) in enumeration_request()
- Commit:
0ab4c95723904e176687f5edc131bdf422dd261a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
Bring back object enumeration inside got-read-pack as a fast path.
The problem that was found in the earlier version has been fixed.
ok op@
- Commit:
e44d939152693c16e95d2855b539ad6b30e81b15
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
revert object enumeration in got-read-pack for now; needs more work
This implementation marked commits and trees as enumerated before all trees
which they depend on were enumerated. This behaviour leads to incomplete
pack files when a tree is only partially packed and got-read-pack hits
a missing tree entry as a result. The algorithm must be reworked such
that packed leave nodes are marked enumerated first, then bubble-up.
Found by op@
- Commit:
0e90588fc653d9ef0965c9420e8c39f615393b0d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
in enumeration_request(), use the correct index for tagged commit objects
Fixes an error where got-read-pack errors out with "bad object data"
during 'got send' because we ended up handing a tag object to the
commit object parser.
- Commit:
cee6a7ea556f9f3ae0f50df959c2acd8cb59bf80
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
implement object enumeration support in got-read-pack
ok op@
- Commit:
dac5c75ed0c009997c4b71cb83bfaebbfaff22f1
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
convert delta cache to a hash table
This approach uses more memory but is much faster. To offset the
additional memory usage somewhat the cache now stores very small
deltas only. However, overall memory usage goes up. Hopefully we
will find a way to reduce this later.
ok op@
- Commit:
1453347d2463ce1b2700dd9fa810f30f2a443e5e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
imsg_add() frees its msg argument on error; avoid double-free in error paths
- Commit:
9985f404ff5dc911b6186e5fa6233fa36848a19a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
parse tree entries into an array instead of a pathlist
Avoids some extra malloc/free in a performance-critical path.
ok op@
- Commit:
fae7e03842e8618973f4d4910a86a52d881ab2ab
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
run the search for deltas to reuse in got-read-pack
This significantly speeds up the deltification step of packing by
avoiding imsg traffic. gotadmin no longer requests individual raw
deltas from got-read-pack to check whether it can reuse them.
Instead, got-read-pack obtains a list of objects we want to pack,
and hands back the list of all deltas in its pack file which can be
reused. Messages are now batched such that imsg buffers are filled
as much as possible.
Another advantage is that deltas we are not going to reuse will
no longer be written to the delta cache file, saving disk space.
Before this patch, any raw delta candidate was written to the
delta cache file by got-read-pack, and the decision whether to
reuse the delta happened afterwards in the gotadmin process.
Code for reading individual raw deltas is now unused and could be
removed at some point.
ok op@
- Commit:
2d9e6abf243a0a1895786fa9002b28d69a0f6fea
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
store deltas in compressed form while packing, both in memory and cache file
This reduces memory and disk space consumption during packing.
with tweaks + memleak on error fix from op@
ok op@
- Commit:
d7b5a0e827bb38e5c8502f0ba8d7838fedaba19b
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
inline struct got_object_id in struct got_object_qid
Saves us from doing a malloc/free call for every item on the list.
ok op@
- Commit:
67fd68496517d3103b130a1085efdd4591bd7416
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reuse existing deltas when creating pack files
tested by thomas, naddy, and myself