commit e485d53ccedd8763e8b66aefb2d491487e6d73c0
from: Omar Polo <op@omarpolo.com>
via: Thomas Adam <thomas@xteddy.org>
date: Fri Oct 28 15:22:17 2022 UTC

change add_delta to take an off_t instead of size_t.

add_delta already calls got_delta_open casting the size_t to off_t, and
all the add_delta callers pass an off_t anyway; fixes an implicit off_t
truncation.

ok stsp@

commit - 1dc5ea0c03cb3abc7e1d6646aae735ebbae60045
commit + e485d53ccedd8763e8b66aefb2d491487e6d73c0
blob - 2a560634ba3ed0a4d9d0ba1e4f88286a3a762951
blob + 2d666ed27a880d2f0d3809c5a2e9f56c721952a3
--- lib/pack.c
+++ lib/pack.c
@@ -1030,7 +1030,7 @@ read_delta_data(uint8_t **delta_buf, size_t *delta_len
 
 static const struct got_error *
 add_delta(struct got_delta_chain *deltas, off_t delta_offset, size_t tslen,
-    int delta_type, size_t delta_size, size_t delta_data_offset)
+    int delta_type, size_t delta_size, off_t delta_data_offset)
 {
 	struct got_delta *delta;
 
@@ -1073,7 +1073,7 @@ resolve_offset_delta(struct got_delta_chain *deltas,
 	}
 
 	err = add_delta(deltas, delta_offset, tslen, delta_type, delta_size,
-	    delta_data_offset);	/* XXX: off_t vs size_t! */
+	    delta_data_offset);
 	if (err)
 		return err;
 
@@ -1148,7 +1148,7 @@ resolve_ref_delta(struct got_delta_chain *deltas, stru
 	}
 
 	err = add_delta(deltas, delta_offset, tslen, delta_type, delta_size,
-	    delta_data_offset);	/* XXX: off_t vs size_t */
+	    delta_data_offset);
 	if (err)
 		return err;