commit e8c5d4f87401e77adfdec88437f3b973e7b47262
from: Stefan Sperling <stsp@stsp.name>
via: Thomas Adam <thomas@xteddy.org>
date: Tue Mar 19 13:37:06 2024 UTC

reuse existing repository struct in gotd session update_ref()

Avoids pointlessly opening and closing a separate repository instance.

commit - a8938c43582703be3f5912d0147fc275d314204a
commit + e8c5d4f87401e77adfdec88437f3b973e7b47262
blob - 267e7ef666d0878c08135b645d1a918e641ad989
blob + ebe568d9449b25eac52742c96be60d186d6244e8
--- gotd/session.c
+++ gotd/session.c
@@ -402,7 +402,7 @@ update_ref(int *shut, struct gotd_session_client *clie
     const char *repo_path, struct imsg *imsg)
 {
 	const struct got_error *err = NULL;
-	struct got_repository *repo = NULL;
+	struct got_repository *repo = gotd_session.repo;
 	struct got_reference *ref = NULL;
 	struct gotd_imsg_ref_update iref;
 	struct got_object_id old_id, new_id;
@@ -429,10 +429,6 @@ update_ref(int *shut, struct gotd_session_client *clie
 		return got_error_from_errno("strndup");
 
 	log_debug("updating ref %s for uid %d", refname, client->euid);
-
-	err = got_repo_open(&repo, repo_path, NULL, NULL);
-	if (err)
-		goto done;
 
 	memcpy(old_id.sha1, iref.old_id, SHA1_DIGEST_LENGTH);
 	memcpy(new_id.sha1, iref.new_id, SHA1_DIGEST_LENGTH);
@@ -556,8 +552,6 @@ done:
 	}
 	if (ref)
 		got_ref_close(ref);
-	if (repo)
-		got_repo_close(repo);
 	free(refname);
 	free(id);
 	return err;