commit ef4f8ddaffcf814c74e3e3d806e430aeea45d7e8
from: Ted Unangst <tedu@tedunangst.com>
date: Mon May 06 01:47:01 2024 UTC

switch to using readdir. readdir_r is deprecated.

commit - b808e01085d775b284878dfeea5c06339a9f2ec2
commit + ef4f8ddaffcf814c74e3e3d806e430aeea45d7e8
blob - 4030a4d264d4215f29156813c7768ef76da921b2
blob + 5bcbcfa6ca6a299f58ac1d654a279b51a3b29ad4
--- lib/fileindex.c
+++ lib/fileindex.c
@@ -925,28 +925,32 @@ diff_fileindex_dir(struct got_fileindex *, struct got_
     struct got_pathlist_head *, int, const char *, const char *,
     struct got_repository *, struct got_fileindex_diff_dir_cb *, void *);
 
+static struct dirent *
+copy_dirent(const struct dirent *de)
+{
+	size_t amt = de->d_reclen;
+	struct dirent *copy;
+
+	copy = malloc(amt);
+	if (copy != NULL) {
+		memcpy(copy, de, amt);
+	}
+	return copy;
+}
+
 static const struct got_error *
 read_dirlist(struct got_pathlist_head *dirlist, DIR *dir, const char *path)
 {
 	const struct got_error *err = NULL;
 	struct got_pathlist_entry *new = NULL;
-	struct dirent *dep = NULL;
 	struct dirent *de = NULL;
 
 	for (;;) {
-		de = malloc(sizeof(struct dirent) + NAME_MAX + 1);
-		if (de == NULL) {
-			err = got_error_from_errno("malloc");
-			break;
-		}
-
-		if (readdir_r(dir, de, &dep) != 0) {
-			err = got_error_from_errno("readdir_r");
-			free(de);
-			break;
-		}
-		if (dep == NULL) {
-			free(de);
+		errno = 0;
+		if ((de = readdir(dir)) == NULL) {
+			if (errno != 0) {
+				err = got_error_from_errno("readdir");
+			}
 			break;
 		}
 
@@ -956,10 +960,14 @@ read_dirlist(struct got_pathlist_head *dirlist, DIR *d
 		    strcmp(de->d_name, GOT_WORKTREE_GOT_DIR) == 0) ||
 		    (path[0] == '\0' &&
 		    strcmp(de->d_name, GOT_WORKTREE_CVG_DIR) == 0)) {
-			free(de);
 			continue;
 		}
 
+		de = copy_dirent(de);
+		if (de == NULL) {
+			err = got_error_from_errno("malloc");
+			break;
+		}
 		err = got_pathlist_insert(&new, dirlist, de->d_name, de);
 		if (err) {
 			free(de);