Commit Briefs

Stefan Sperling

change gotwebd.conf fcgi socket syntax to "listen on 'foo' port 'bar'"

ok op@

diff | patch | tree

Omar Polo

gotwebd: fix NULL deref on ENOMEM in gotweb_process_request

ok tracey@

diff | patch | tree

Omar Polo

gotwebd: fix memory leak introduced in d927f8c

ok tracey@

diff | patch | tree

Josh Rickmar

don't create signed tag objects with trailing NUL

Although Git itself did not care, the superfluous NUL at the end of the tag object was breaking GitHub's SSH signature detection. ok stsp@

diff | patch | tree

Omar Polo

gotwebd: add CSP policy

ok tracey@

diff | patch | tree

Omar Polo

gotwebd: fix for possible NULL beign passed to fcgi_printf

reported by and ok tracey@

diff | patch | tree

Omar Polo

gotwebd: make sure to escape possibly unsafe strings

this fixes only the HTML escaping of strings, the urlencode is still missig. while here also plug a memory leak in gotweb_render_branches and drop some needless ternary operators. ok tracey@

diff | patch | tree

Omar Polo

gotwebd: minor tweaks to the generated HTML

spotted by validator.w3.org: - use target="_blank" instead of `_sotd' - drop `alt' attributes in `a' tags This fixes all the errors reported; only a warning suggesting to add a `lang' attribute on the <html> tag remains.

diff | patch | tree

Stefan Sperling

mark functions internally used by sockets.c as static

ok tracey

diff | patch | tree

Stefan Sperling

fix previous: store port number in host byte order, convert for struct sockaddr

With the previous patch the listen port was correct, but the debug log output was still displaying the swapped port number. Now both listen behaviour and debug log output agree.

diff | patch | tree

Stefan Sperling

fix gotwebd default fcgi listen port byte-order (port 10275 -> port 9000)

ok tracey

diff | patch | tree

Stefan Sperling

gotwebd: listen on localhost only by default

ok tracey

diff | patch | tree

Stefan Sperling

gotwebd: struct socket_conf can only use a single address, so don't use a list

ok tracey

diff | patch | tree

Omar Polo

gotwebd: add fcgi_printf

instead of fcgi_gen_response which outputs only a fixed strings provide a printf-like fcgi_printf: it greatly simplifies the generation of the HTML pages. While here also (probably) fix some HTML errors: the output was verified with the W3C validator and it's correct (in the sense that the tags are properly closed, there are still some other things the validator complains about.) ok/encouragement baseprime@, ok jamsek Thanks for reading such a boring diff!

diff | patch | tree

Omar Polo

fix overflow in blame callback

spotted by noticing gotwebd crashing on some blame requests. Diff from stsp@ with a fix from tracey@, I'm committing it only because he is short on time. ok stsp@

diff | patch | tree

Stefan Sperling

gotwebd: initialize IPv4 and IPv6 sockets in the same way

ok tracey

diff | patch | tree

Stefan Sperling

gotwebd: don't listen on FCGI sockets when FCGI is not enabled

ok tracey

diff | patch | tree

Stefan Sperling

gotwebd: do not allocate server/socket list heads separately

ok millert@

diff | patch | tree

Stefan Sperling

gotwebd: do not allocate address list heads separately, this is unnecessary

ok millert@

diff | patch | tree

Omar Polo

fix snprintf error handling

follow the "proper secure idiom" described in the CAVEATS section of printf(3). reminded by tb@ and millert@

diff | patch | tree

Omar Polo

convert two snprintf to strlcpy

"looks good to me" millert@

diff | patch | tree

Omar Polo

check for fprintf failure

diff | patch | tree

Stefan Sperling

got(1): Replace 'Ar sign' with 'Cm sign'

Cm sign matches the markup used in the ssh-keygen(1) man page. Patch by Josiah Frentsos

diff | patch | tree

Stefan Sperling

regress: adjust expected usage output in "revert_no_arguments" test

diff | patch | tree

Stefan Sperling

Group options in accordance with style(9)

patch by Josiah Frentsos

diff | patch | tree