Commit Briefs

Stefan Sperling

refresh cached list of pack index paths while searching a packed object

Previously, this list was only refreshed while trying to match an object ID prefix. Regular pack file access needs to refresh this list, too. In particular, future gotd(8) needs this to ensure that newly uploaded packfiles are picked up as expected.

diff | patch | tree

Stefan Sperling

switch integers used for counting objects while indexing pack files to unsigned

diff | patch | tree

Stefan Sperling

provide a more useful error if the size of a packed object won't fit in 64 bits

diff | patch | tree

Stefan Sperling

let callers of got_pack_index() configure the rate limit of progress reporting

diff | patch | tree

Stefan Sperling

move pack indexing code into new file lib/pack_index.c

Prepares for sharing code between got-index-pack and future gotd(8).

diff | patch | tree

Stefan Sperling

allow got_object_parse_tree to reuse entries buffer allocations for speed

ok millert@

diff | patch | tree

Stefan Sperling

let callers of got_pack_create() configure rate-limiting of progress reporting

Needed by future gotd(8), where progress reports will be sent to a network socket, rather than a local terminal.

diff | patch | tree

Stefan Sperling

do not crash if no delta cache is present while parsing deltas

diff | patch | tree

Stefan Sperling

move privsep code from pack_create.c into new file pack_create_privsep.c

Needed by future gotd(8). ok op@

diff | patch | tree

Stefan Sperling

handle unlink(2) errors for mergepath, tmppath, and apath in apply_patch()

ok op@

diff | patch | tree

Stefan Sperling

introduce got_path_move_file(); based on code from lib/patch.c

ok op@

diff | patch | tree

Stefan Sperling

check for unlink(2) errors and don't try to unlink an already renamed file

ok op@

diff | patch | tree

Stefan Sperling

check for unlink(2) errors in got_opentempfd()

ok op@

diff | patch | tree

Stefan Sperling

check for unlink(2) errors with the == -1 idiom, rather than != 0

ok op@

diff | patch | tree

Stefan Sperling

move got_opentempfd() call out of got_pack_create()

Future gotd(8) needs to run got_pack_create() in a chroot environment, so we can no longer open new temporary files inside got_pack_create(). ok op@

diff | patch | tree

Stefan Sperling

make got_pack_create() write to a file descriptor instead of a stdio FILE

The old code required a seekable output file. This conflicts with requirements of future gotd(8), which will write pack file data to network sockets. ok op@

diff | patch | tree

Stefan Sperling

simplify the way 'got patch' opens a tempfile when reading from stdin

Also add basic test coverage for reading patches from stdin, while here. ok op@

diff | patch | tree

Stefan Sperling

remove accidentally committed debug assertion

diff | patch | tree

Stefan Sperling

move got_gotconfig_read() into new file read_gotconfig_privsep.c

diff | patch | tree

Stefan Sperling

remove unnecessary includes of got_lib_privsep.h

diff | patch | tree

Stefan Sperling

move declaration of got_privsep_child out of got_lib_privsep.h

This declaration is the only reason why got_lib_privsep.h must be included in order to use got_lib_repository.h. Moving this declaration will allow for cleaning up unnecessary includes of got_lib_privsep.h.

diff | patch | tree

Stefan Sperling

move code for reading Git's config file into new file read_gitconfig_privsep.c

The end goal here is to remove the dependency of repository.c on privsep.c during compilation.

diff | patch | tree

Stefan Sperling

move code which forks child processes into a subroutine, reducing copy-pasta

diff | patch | tree

Stefan Sperling

move functions which open objects into new file object_open_privsep.c

For the future, this will make it possible to provide alternative implementations of functions now stored in object_open_privsep.c. This will probably be needed by future gotd(8) which runs inside a chroot(2) environment and without the "exec" pledge(2) promise, making it impossible to run libexec helpers on the fly. Details of this design are not yet settled, but moving functions into a separate compilation unit won't hurt in any case.

diff | patch | tree

Stefan Sperling

the my_refs reflist in delete_missing_refs() must be freed on exit

diff | patch | tree