Commit Briefs

341fa7cacc Omar Polo

gotwebd: minor tweaks

drop: - a tautological s[strlen(s)] == '\0' - a few duplicates checks - a lone if (error) when it's always NULL - an extra NULL check part of a bigger diff that's ok stsp@


40a95f4f72 Omar Polo

gotwebd: plug leak in fcgi_parse_params

fcgi_parse_params parses fastcgi parameters into a list. (This is a leftover from slowcgi where that list is later used to populate the environment of the CGI process.) However, this list is never looked at and its memory never released, so just drop it. Make the matching on fastcgi parameters name strictier by checking also that the length is the one we expect; otherwise we might pick up parameters with the same prefix string (i.e. FOO vs FOO_WITH_SUFFIX) While here turn some bcopy into memcpy and simplify some if-nesting too. Fix the reading from an un-initialized pointer that I introduced in a previous commit. ok stsp@



0fad85ddfc Omar Polo

gotwebd: refactor gotweb_load_got_path

- don't special case ".got": if it's a work-tree gotwebd will just fail soon enough. Suggested by stsp@ - avoid an strdup. - drop `opened' to make it easier to follow what's going on. ok stsp@


b5c757f5f8 Stefan Sperling

make gotwebd cache open repository handles in struct server

ok op@


d52aad1421 Omar Polo

indent


4010d4df50 Omar Polo

gotwebd: plug two memory leak and drop unneeded ternary

ok tracey@



4924afe127 Mark Jamsek

tog: remove gcc ternary if extension

ok stsp@


3c84334028 Stefan Sperling

add a gotwebd todo item


1d09d7aab4 Stefan Sperling

remove gotwebd TODO items that are done


7cc8fde444 Omar Polo

gotwebd: drop the x bit from assets in-tree and also when installing

ok stsp@


d4f2833aca Omar Polo

wrap overlong line in diff.sh


a97a5e436f Omar Polo

fix NULL deref in the object cache debug code; ok stsp@

it's not in code compiled by default as it's under GOT_OBJ_CACHE_DEBUG.


e9d3ad59c9 Stefan Sperling

fix dup(2) error checking in got_gotweb_openfile()



1999985f9a Tracey Emery

get rid of (null) on the index page. ok stsp



98275f2eef Omar Polo

mark check_refcount as static

needed because of -Wmissig-prototypes; ok stsp@




5e91dae4dd Stefan Sperling

remove trailing whitespace; patch by Josiah Frentsos


95a4a5a1e8 Omar Polo

gotwebd: use SCRIPT_NAME to derive URLs

This makes gotwebd use SCRIPT_NAME instead of the DOCUMENT_ROOT fastcgi param to generate the links to the assets and changes some links so every page is consistently linked with a relative URL. It allows to drop the `root "/"' in the location for fastcgi and, as a bonus, also makes possible to run gotwebd on non "/" paths. ok stsp@


b1328b3e37 Omar Polo

gotwebd: garbage collect %token FCGI_SOCKET

ok stsp@


6c8aa58fb8 Stefan Sperling

remove fcgi_socket keyword from gotwebd.conf; "listen on" now implies it

ok op@