Commit Briefs
plug leak of got_diffreg_result on output failure
Move 'done' labels up so that if got_diffreg_output() fails we still call got_diffreg_result_free() instead of jumping straight over it. ok + fix from stsp@
got: implement diffstat for got log and tog diff view
Add new got_diff_blob_cb() implementation to compute added/removed line metrics for a given diff. This enables displaying a diffstat with 'got log -d'. As per suggestion from stsp, change tog diff view to display the diffstat by default. ok stsp@
backout 169b163113a6db9878c9166aa05fbd30d05eb832
pushed by mistake, wasn't reviewed.
template.7: fix double spaces
diff from Josiah Frentsos and clue from tb@, thanks! (I can't read.)
template.7: Add a missing \& where needed
based on a diff by Josiah Frentsos, thanks!
template.7: Use -width instead of -indent
diff from Josiah Frentsos, thanks!
template.7: use An instead of Ar in AUTHORS
diff from Josiah Frentsos, thanks!
template.1: Use -std with Ex
diff from Josiah Frentsos, thanks!
gotwebd: templateify gotweb_render_diff
To avoid calling functions from got_operations.c directly from a template (which would hide the error), change got_output_repo_diff into got_open_diff_for_output that returns a file with the diff in it, to be then rendered by the template. got_gotweb_flushfile needs to be exposed then. It also bundles a smaller change: the `label' argument of got_repo_match_object_id is optional and not used, so just pass NULL there.
template: drop tmpl.c from SRCS
was added there mistakenly. it's not part of the "compiler", it's part of the "user library" and provides useful functions for the consumers.
gotwebd: urlencode also the double quote character
URLs are embedded as part of the HTML and, while it seems legal from RFC3986 to leave that character unquoted, we need it quoted to avoid breaking the HTML output. ok tracey@
gotwebd: templateify gotweb_render_tree
ok tracey@
gotwebd: css: fix horizontal overflow in blob and blame pages
spotted by + "looks good" tracey@
gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs
binary blobs are automatically redirected to the BLOBRAW page (which is the old BLOB.) ok jamske
revoke filesystem access in gotd listen process via unveil(2)
This should avoid involuntary use of bind(2) with arbitrary socket paths. ok op@
expose 'gotctl info' output only to the root user
Now that anyone can connect to the socket, it is probably safer to expose information about currently connected clients only to root.
gotwebd.conf: use `listen on socket' syntax for UNIX sockets too
and drop unix_socket and unix_socket_path in server context. ok stsp@
remove the gotsh group requirement from gotd; any user can now connect
Repository access is now controlled by access rules in gotd.conf, and concurrent connections to the gotd socket by local users are limited by the listen process. We should keep refining our anti-DoS measures in the future, but at least we have something in place now. ok jamsek, op
gotwebd: rework got_output_file_blob, no functional change
can now use got_object_blob_is_binary to simplify the logic. ok stsp@