Commit Briefs
add -d switch to log usage and sort lexicographically
patch by Josiah Frentsos
regress: replace echo \n with printf and heredoc
echo \n is not really portable. Not that it matters since the regress suite is already using non-POSIX features (like `local'). However, it's the only place using it and easy to fix. ok jamsek
plug leak of got_diffreg_result on output failure
Move 'done' labels up so that if got_diffreg_output() fails we still call got_diffreg_result_free() instead of jumping straight over it. ok + fix from stsp@
got: implement diffstat for got log and tog diff view
Add new got_diff_blob_cb() implementation to compute added/removed line metrics for a given diff. This enables displaying a diffstat with 'got log -d'. As per suggestion from stsp, change tog diff view to display the diffstat by default. ok stsp@
backout 169b163113a6db9878c9166aa05fbd30d05eb832
pushed by mistake, wasn't reviewed.
template.7: fix double spaces
diff from Josiah Frentsos and clue from tb@, thanks! (I can't read.)
template.7: Add a missing \& where needed
based on a diff by Josiah Frentsos, thanks!
template.7: Use -width instead of -indent
diff from Josiah Frentsos, thanks!
template.7: use An instead of Ar in AUTHORS
diff from Josiah Frentsos, thanks!
template.1: Use -std with Ex
diff from Josiah Frentsos, thanks!
gotwebd: templateify gotweb_render_diff
To avoid calling functions from got_operations.c directly from a template (which would hide the error), change got_output_repo_diff into got_open_diff_for_output that returns a file with the diff in it, to be then rendered by the template. got_gotweb_flushfile needs to be exposed then. It also bundles a smaller change: the `label' argument of got_repo_match_object_id is optional and not used, so just pass NULL there.
portable: OpenBSD support
Despite -portable existing to make the codebase compile on platforms other than OpenBSD, there's nothing wrong with making -portable still compile on that platform as well.
portable: configure.ac: fix libpanelw detection
When not using pkg-config on those systems where it isn't installed, libpanelw should be checked within ncursesw as well -- such is the case on OpenBSD for example.
portable: sha1.h
This is included portably.
template: drop tmpl.c from SRCS
was added there mistakenly. it's not part of the "compiler", it's part of the "user library" and provides useful functions for the consumers.
gotwebd: urlencode also the double quote character
URLs are embedded as part of the HTML and, while it seems legal from RFC3986 to leave that character unquoted, we need it quoted to avoid breaking the HTML output. ok tracey@
gotwebd: templateify gotweb_render_tree
ok tracey@
gotwebd: css: fix horizontal overflow in blob and blame pages
spotted by + "looks good" tracey@