Commit Briefs

4f1ecad819 Thomas Adam

fix D_GOTWWW default path; gotweb can now run without a config file again

ok tracey


df67eb78ca Thomas Adam

clear the rest of the pack_fds pointers


1b4d350c1e Thomas Adam

clear gw_trans->pack_fds pointer in gotweb


e0fb2ce217 Thomas Adam

fix recent regression in gotweb for pack_fds






1af5eddf22 Thomas Adam

fix handling of pack_fds used by tog's log thread


7cd528337b Thomas Adam

move got_opentempfd out of got_repo_open. ok stsp@

thanks for all the help massaging this diff


04cdf6acc3 Thomas Adam

check for errors from fclose() in patch_file()


25054c242b Thomas Adam

plug memory and fd leak in got patch


23427b1425 Thomas Adam

re-add u/d keybindings as aliases for Ctrl-u/d, matching more(1) and less(1)

patch by Mikhail


8f3ec65d21 Thomas Adam

fix a harmless off-by-one from previous commit


ef53e23c28 Thomas Adam

fix a bug in got_privsep_send_object_idlist() exposed by recent changes

The old code did not work correctly if only a single object Id was to be sent to got-read-pack. Make got-read-pack error out if the list of commits for object enumeration is empty to catch this problem if it occurs again. Found by the send_basic test, which was failing with GOT_TEST_PACK=1 ok tracey


e71f1e62dd Thomas Adam

let got-read-pack be explicit about whether it could enumerate all objects

This allows the main process to avoid looping over all object IDs again in case the pack file used for enumeration is complete. ok op@



774020352c Thomas Adam

remove trailing whitespaces


623d55de6e Thomas Adam

compute object size, not pointer size

in this case they're luckily the same; got_imsg_object_idlist and got_imsg_reused_delta only have one size_t long field. ok stsp@


31d3263499 Thomas Adam

strictier validation for data received from libexec helpers

use correct error code and ok stsp@


12a8238ea9 Thomas Adam

drop unused variable


79b7acf3bc Thomas Adam

use strndup instead of malloc+memcpy

Simplifies the reading of the author/committer string and makes also the code shorter. ok stsp@


c24fd27082 Thomas Adam

don't check datalen when calling recv_imsg_error

recv_imsg_error already checks the size of the message, and it does so more precisely than the removed code. ok stsp@


8ebb3daa77 Thomas Adam

got patch: use ints for line offsets instead of longs

ints have the advantage that their size is more likely to be the same across the various architecture supported by OpenBSD, thus introducing less possible differences. INT_MAX is still (at least) a few order of magnitudes higher than the patches we dealt with (even abnormal ones.) suggested by stsp@


06227823b7 Thomas Adam

actually guarding against negative line offsets

previous commit looked at some pretty zeroes returned from calloc instead of the actual numbers received.