Commit Briefs

Stefan Sperling

CHANGES for 0.98 (tags/0.98)


Stefan Sperling

sync dist file list


Stefan Sperling

extend test_patch_empty_file() test coverage

Check what happens when patches attempt to edit or delete empty files.


Omar Polo

got patch: fix applying on empty files

if we've reached EOF without finding a match is fine if and only if the target file is empty, so add this exception. reported by naddy, ok stsp


Omar Polo

got-notify-http: use a UNIX timestamp for the date

Was suggested by Lucas some time ago. ok stsp@ with a tweak in the manual.






Stefan Sperling

require -R option for staging or unstaging directory contents

-R is needed on almost all other commands so this makes things consistent. Patch by Lorenz (xha)


Stefan Sperling

make got-fetch-http pass "done\n" through rather than faking it

Without this we exit the loop early and got-fetch-pack sees unexpected end-of-file on stdout trying to write its final "done\n" message. ok op@




Tobias Heider

Move pkt-len parsing to a separate got_pkt_readlen() function

so we can reuse it in other places like got-fetch-http later. ok op@ stsp@


Omar Polo

got-notify-http: fix I/O with TLS

tls_write() may return TLS_WANT_READ. In that case, we're stuck trying to read while we have the request still in the buffer. So, we have to retry bufio_write() regardless of the POLLIN/POLLOUT state. We'd need this only in the TLS case, but in practice it doesn't harm for the plaintext case too. In fact, we're either waiting to flush the request or we're only reading the server reply. ok stsp



Stefan Sperling

send got-http-notify error output to syslog

ok op@



Stefan Sperling

make it harder to leak notification credentials over plaintext HTTP

ok op@





Stefan Sperling

remove dead code under DEBUG_HTTP; ok op@


Stefan Sperling

use unveil to restrict filesystem access of got-fetch-http

With HTTPS we only need to be able to read /etc/ssl/cert.pem. With plaintext HTTP no filesystem access is needed at all.