Commit Briefs

Thomas Adam

got: implement diffstat for got log and tog diff view

Add new got_diff_blob_cb() implementation to compute added/removed line metrics for a given diff. This enables displaying a diffstat with 'got log -d'. As per suggestion from stsp, change tog diff view to display the diffstat by default. ok stsp@


Thomas Adam

backout 169b163113a6db9878c9166aa05fbd30d05eb832

pushed by mistake, wasn't reviewed.


Thomas Adam

template.7: fix double spaces

diff from Josiah Frentsos and clue from tb@, thanks! (I can't read.)


Thomas Adam

template: bump date in manpages


Thomas Adam

template.7: Add a missing \& where needed

based on a diff by Josiah Frentsos, thanks!


Thomas Adam

template.7: Use -width instead of -indent

diff from Josiah Frentsos, thanks!


Thomas Adam

template.7: use An instead of Ar in AUTHORS

diff from Josiah Frentsos, thanks!


Thomas Adam

template.1: Use -std with Ex

diff from Josiah Frentsos, thanks!


Thomas Adam

gotwebd: templateify gotweb_render_diff

To avoid calling functions from got_operations.c directly from a template (which would hide the error), change got_output_repo_diff into got_open_diff_for_output that returns a file with the diff in it, to be then rendered by the template. got_gotweb_flushfile needs to be exposed then. It also bundles a smaller change: the `label' argument of got_repo_match_object_id is optional and not used, so just pass NULL there.


Thomas Adam

portable: OpenBSD support

Despite -portable existing to make the codebase compile on platforms other than OpenBSD, there's nothing wrong with making -portable still compile on that platform as well.


Thomas Adam

portable: configure.ac: fix libpanelw detection

When not using pkg-config on those systems where it isn't installed, libpanelw should be checked within ncursesw as well -- such is the case on OpenBSD for example.


Thomas Adam

portable: sha1.h

This is included portably.


Thomas Adam

template: specify which C loop


Thomas Adam

template: add `while' construct


Thomas Adam

switch gotd.conf syntax from 'unix_socket' to 'listen on'

ok op@


Thomas Adam

template: drop tmpl.c from SRCS

was added there mistakenly. it's not part of the "compiler", it's part of the "user library" and provides useful functions for the consumers.



Thomas Adam

gotwebd: urlencode also the double quote character

URLs are embedded as part of the HTML and, while it seems legal from RFC3986 to leave that character unquoted, we need it quoted to avoid breaking the HTML output. ok tracey@


Thomas Adam

gotwebd: templateify gotweb_render_tree

ok tracey@


Thomas Adam

gotwebd: css: fix horizontal overflow in blob and blame pages

spotted by + "looks good" tracey@


Thomas Adam

gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs

binary blobs are automatically redirected to the BLOBRAW page (which is the old BLOB.) ok jamske


Thomas Adam

provide a getline-style function for blobs

ok jamsek


Thomas Adam

revoke filesystem access in gotd listen process via unveil(2)

This should avoid involuntary use of bind(2) with arbitrary socket paths. ok op@


Thomas Adam

expose 'gotctl info' output only to the root user

Now that anyone can connect to the socket, it is probably safer to expose information about currently connected clients only to root.


Thomas Adam

gotwebd.conf: use `listen on socket' syntax for UNIX sockets too

and drop unix_socket and unix_socket_path in server context. ok stsp@