Commit Briefs

ad422caf47 Thomas Adam

backout 169b163113a6db9878c9166aa05fbd30d05eb832

pushed by mistake, wasn't reviewed.


d2b972f8ab Thomas Adam

template.7: fix double spaces

diff from Josiah Frentsos and clue from tb@, thanks! (I can't read.)


ff94576882 Thomas Adam

template: bump date in manpages


e9c42ba808 Thomas Adam

template.7: Add a missing \& where needed

based on a diff by Josiah Frentsos, thanks!


4ed38987e5 Thomas Adam

template.7: Use -width instead of -indent

diff from Josiah Frentsos, thanks!


d0b178c551 Thomas Adam

template.7: use An instead of Ar in AUTHORS

diff from Josiah Frentsos, thanks!


bf92bf9b79 Thomas Adam

template.1: Use -std with Ex

diff from Josiah Frentsos, thanks!


5d860bcebe Thomas Adam

gotwebd: templateify gotweb_render_diff

To avoid calling functions from got_operations.c directly from a template (which would hide the error), change got_output_repo_diff into got_open_diff_for_output that returns a file with the diff in it, to be then rendered by the template. got_gotweb_flushfile needs to be exposed then. It also bundles a smaller change: the `label' argument of got_repo_match_object_id is optional and not used, so just pass NULL there.


f600ad7605 Thomas Adam

portable: OpenBSD support

Despite -portable existing to make the codebase compile on platforms other than OpenBSD, there's nothing wrong with making -portable still compile on that platform as well.


947fe78cd6 Thomas Adam

portable: configure.ac: fix libpanelw detection

When not using pkg-config on those systems where it isn't installed, libpanelw should be checked within ncursesw as well -- such is the case on OpenBSD for example.


171ba12ab6 Thomas Adam

portable: sha1.h

This is included portably.


9a7a36e8b4 Thomas Adam

template: specify which C loop


3594b24d3e Thomas Adam

template: add `while' construct


f9a4feb61d Thomas Adam

switch gotd.conf syntax from 'unix_socket' to 'listen on'

ok op@


8713f7b22e Thomas Adam

template: drop tmpl.c from SRCS

was added there mistakenly. it's not part of the "compiler", it's part of the "user library" and provides useful functions for the consumers.


0d26b72c23 Thomas Adam

gotd: delete unreachable code after gotd_shutdown()


e1a9403aed Thomas Adam

gotwebd: urlencode also the double quote character

URLs are embedded as part of the HTML and, while it seems legal from RFC3986 to leave that character unquoted, we need it quoted to avoid breaking the HTML output. ok tracey@


3c14c1f287 Thomas Adam

gotwebd: templateify gotweb_render_tree

ok tracey@


af0d6ce189 Thomas Adam

gotwebd: css: fix horizontal overflow in blob and blame pages

spotted by + "looks good" tracey@


b82440e1f4 Thomas Adam

gotwebd: render BLOB inline, add BLOBRAW for serving raw blobs

binary blobs are automatically redirected to the BLOBRAW page (which is the old BLOB.) ok jamske


ae30b71463 Thomas Adam

provide a getline-style function for blobs

ok jamsek


d4940d4006 Thomas Adam

revoke filesystem access in gotd listen process via unveil(2)

This should avoid involuntary use of bind(2) with arbitrary socket paths. ok op@


c8cf682107 Thomas Adam

expose 'gotctl info' output only to the root user

Now that anyone can connect to the socket, it is probably safer to expose information about currently connected clients only to root.


bea82c4f04 Thomas Adam

gotwebd.conf: use `listen on socket' syntax for UNIX sockets too

and drop unix_socket and unix_socket_path in server context. ok stsp@


f2fc8ce0a3 Thomas Adam

remove the gotsh group requirement from gotd; any user can now connect

Repository access is now controlled by access rules in gotd.conf, and concurrent connections to the gotd socket by local users are limited by the listen process. We should keep refining our anti-DoS measures in the future, but at least we have something in place now. ok jamsek, op