Commit Briefs

b0ca001af3 Thomas Adam

remove stray tab that snuck in


d356bf7597 Thomas Adam

display GMT offset in cat command

ok stsp


e2752401e9 Thomas Adam

factorize imsg_clear calls after imsg_flush failures

imsg_clear frees and closes resources allocated as part of enqueueing imsgs so it's a no-op after reads. discussed with and ok stsp@


4049b748bf Thomas Adam

fix fd leak in got_fetch_pack, ok stsp@


9389bcf69b Thomas Adam

portable: fix use of d->namlen

As done elsewhere, d->namlen is not a portable field from readdir, therefore simualte this via the strlen of the directory name instead.



f9c2e8e5d5 Thomas Adam

reuse existing deltas when creating pack files

tested by thomas, naddy, and myself


d2f35ef7f7 Thomas Adam

shrink the width of formatted output fields to their expected size

Replace FMT_SCALED_STRSIZE with (FMT_SCALED_STRSIZE - 2) as field width when formatting output for printing. FMT_SCALED_STRSIZE includes space for a nul byte and a minus sign. Output values are expected to be always positive here. ok stsp


90dfa2bf41 Thomas Adam

consistently match size of hash variables to that returned by murmurhash

ok millert stsp


ebdfb05bcd Thomas Adam

portable: add murmurhash2 to deltify test

Add missing include for the deltify test now that it depends on murmurhash2.






8f666e6727 Thomas Adam

tweak error reporting due to invalid numbers

Use the same idiom as in the strtonum(3) manpage which produces a more readable error message. OK kn, stsp


9c8bf18964 Thomas Adam

set zlib output buffer length properly after resizing the output buffer

ok millert naddy


f6a55b4019 Thomas Adam

fix infinite loop in got-index-pack for pack files >= 4GB in size

Because of a missing range check our zlib wrapper would end up calling zlib over and over with zero bytes of input. Problem reported by semarie and naddy. Fixed with help from millert@. ok millert naddy


17431c138a Thomas Adam

improve error message due to malformed `author' in got.conf

tweak and ok stsp@


84bf00a657 Thomas Adam

improve 'got add' error message if file does not exist; reported by Timo Myyrä

ok tracey


9b31ed6506 Thomas Adam

fix loose object file header parser for zero-length headers

ok millert tracey



a75b210eed Omar Polo

dropping unused includes


9cefc4c1a6 Omar Polo

fix landlock usage: handled_access_fs must list all actions

The ruleset's handled_access_fs has to list all the defined actions because otherwise missing ones are implicitly permitted. Thus, the previous version ended up allowing "almost everything" except reading files. Original diff from Mickaël Salaün, thanks! ok thomas


5e997b0139 Omar Polo

s/ENOTSUP/EOPNOTSUPP/

linux defines these errors to the same values, but the landlock doc uses `EOPNOTSUPP' consistently. Spotted initially by brynet@ and reminded by Mickaël Salaün, thanks! ok thomas


97799ccd4b Thomas Adam

portable: add support for landlock

landlock is a new set of linux APIs that is conceptually similar to unveil(2): the idea is to restrict what a process can do on a specified part of the filesystem. There are some differences in the behaviour: the major one being that the landlock ruleset is inherited across execve(2). This just restricts the libexec helpers by completely revoking ANY filesystem access; after all they are the biggest attack surface. got send/fetch/clone *may* end up spawning ssh(1), so at the moment is not possible to landlock the main process. From Omar Polo.