got_repo_pack_fds_close will try to close all of the GOT_PACK_NUM_TEMPFILES fds, even the ones that didn't manage to get a value from got_opentempfd(), which would result in a close(0) if we do not initialize to -1 here.

With the narrow scope of bytes_sent_cur it would always be zero, and we would always update progress. Found by llvm's scan-build (Dead store). OK stsp

Found by llvm's scan-build. OK stsp

Found by llvm's scan-build. OK stsp

Found by llvm's scan-build (bad free). OK stsp

This can't happen in practice, but llvm's scan-build doesn't know this. OK stsp

Found by llvm's scan-build (dead store). OK stsp

Found by llvm's scan-build (dead store). OK stsp

Found by llvm's scan-build (dead store). OK stsp

Found by llvm's scan-build (dead store). OK stsp

OK stsp

Found by llvm's scan-build (dead store). OK stsp

Found by llvm's scan-build (dead store). OK stsp

ok tracey

As per stsp's TODO item: open a log view of the selected line with 'L'. helped by and ok stsp@

With permission from Jelmer Vernooij to use my pull request config for Dulwich, and Jelmer's name, as a real-life example. ok tracey, jamsek

otherwise prints the author instead of the committer

Use J and K to move to the next and previous commits, respectively, when the diff is loaded from the log or blame views. Patch by Mikhail ok stsp@

This adds a new flag, `got commit -A', that allows to specify the commit author but retains the "committer" (which is obtained as usual via GOT_AUTHOR, got.conf or git config.) with lots of help from and ok stsp

we were both too strict and too lose. To avoid breaking got object parser (and to some extent ours too) we need to ensure that there aren't any line feeds, extra < or > and no trailing gibberish. The '@' is not actually required in the email. various tweaks and ok stsp

improvements and ok by jamsek and stsp