Commit Briefs

cdbe1d7d5e Thomas Adam

move use of sin_len out of gotwebd's parse.y

ok tracey


82a8b7ecf5 Thomas Adam

rework got patch -c documentation

ok op@




e2273eeb07 Thomas Adam

tweak op@ log_debug output


460244b712 Thomas Adam

fix logging of fcgi_send_response

as originally intended by tracey@


a5a99557db Thomas Adam

gotwebd: handle partial writes

fcgi_send_response can end up trying to send big amount of data, in particular when serving blobs. if a write failure occurs, gotwebd and httpd go out of sync and "bad stuff happens". debugged with and ok tracey@


57d4848d96 Thomas Adam

gotwebd: simplify got_output_file_blob loop

there's no need to distinguish between plain text blob and a binary one in the output, just send it chunk by chunk. ok tracey@


f24996f194 Thomas Adam

gotwebd: simplify isbinary


0c2c6365f8 Thomas Adam

implement fcgi_gen_response on top of fcgi_gen_binary_response

ok tracey@


d54f10aa3f Thomas Adam

gotwebd: fix double Content-Type (and the typo)

ok tracey@


ef0937d6aa Thomas Adam

warn about the interaction between got patch -p and -c

suggested by stsp@


7d8bcb99cc Thomas Adam

got patch: add -c flag to apply at a specified commit

it's useful for e.g. to apply old patches that weren't generated by `got diff' or git-diff(1) and so lacks the metadata needed for the 3-way merge. manpage improvements from and ok stsp@


2194821212 Thomas Adam

simplify got_patch/apply_patch to call reverse_patch in one place once

Current code is overly complex; it looks if the diff *might* use diff3 merge to postpone reverse_patch until we know for sure. Instead, just reverse_patch in apply_patch once we know if merge *is* used or not.


831297da02 Thomas Adam

add a simple test for 'got diff' against CRLF files



7224234d05 Thomas Adam

`got patch' pledge early

ok stsp@


aec48c6cc2 Thomas Adam

got patch: error if patchfile isn't a regular file

`got patch' cannot read patches from non-regular files for obvious reasons. However, it could crash in sendmsg because pledge doesn't allow to send file descriptors referring to directories. So, restrict `got patch' to operate on regular files only and fail otherwise. This still allows to read patches from symlinks since they're resolved at open(2) time and the file type check is performed after. There may be a marginal usefullness in reading patches from fifos, but the current code doesn't allow that anyway since got-read-patch needs a seekable file descriptor anyway. ok tracey@


e4a6dbc6cd Thomas Adam

fix off_t type mismatches

off_t is a signed type and depending on the platform, it can be "long" or "long long", so cast to long long for printf(). ok stsp


33f9ea25c7 Thomas Adam

tweak cmd_info; no functional changes intended

* don't allocate unused pack_fds * drop wpath, cpath, proc, exec and sendfd pledge promises * close the worktree ok stsp@


95ad1e7d02 Thomas Adam

don't undef GOT_AUTHOR in regress

unset only in the subshell so further cose is unaffected. ok stsp@


1f24009200 Thomas Adam

use GOT_IGNORE_GITCONFIG in regress

fixes test_rebase_no_author_info when a valid ~/.gitconfig is found. ok stsp@


7e91f3d2e1 Thomas Adam

read_gitconfig: fix GOT_IGNORE_GITCONFIG case

set gitconfig_remotes to NULL to avoid a double-free, and reset the global author name/email fields too. ok stsp@


2a31b33bf6 Thomas Adam

tog: refactor key map -> new view initialisation

Deduplicate view initialisation boilerplate and simplify new key map view requests with dispatch routine. Includes improvements suggested by stsp. ok stsp@


5daf5c5328 Thomas Adam

add a way to ignore author and remote repository info found in Git config files

ok op@