Commit Briefs

d38635a394 Thomas Adam

gotwebd: got_output_file_blame: free lines on error path

ok stsp@


d3a6241d26 Thomas Adam

gotwebd: free eline in got_gotweb_blame_cb loop

ok stsp@


d5a6a0f390 Thomas Adam

gotwebd: drop superfluous check

commit_id is not NULL if got_repo_match_object_id returned successfully. ok stsp@


7a800a02c4 Thomas Adam

sync file with diff.git 279d77aa1e4b921090e702a6a8a5a94a98a062b1 and

use the faster headers-only mode for diff3



0632533073 Thomas Adam

gotwebd: kill unused id_str in got_output_repo_tree

ok stsp@


ccff619c12 Thomas Adam

gotwebd: avoid extra strdups in got_output_repo_tree

ok stsp@


557d32ee82 Thomas Adam

gotwebd: avoid extra variable in got_output_repo_tree

in_repo_path was used only to build a path, it's then assigned to path (which is NULL at that point.) Just asprintf into path. ok stsp@


06714b03a4 Thomas Adam

Do not segfault verifying "lightweight" tags

ok stsp@


df9fed0915 Thomas Adam

gotwebd: plugs leaks in got_get_repo_commits

call got_get_repo_commit only once and avoid leaking the field of repo_commit at each loop iteration. ok stsp@



4d0573ec49 Thomas Adam

gotwebd: always free ref in got_get_repo_commits

some code-paths may leak it. ok stsp@


acd4ff87e5 Thomas Adam

gotwebd: don't close tag in got_get_repo_tags too early

it's still used a bit later, so defer the free'ing at the next loop iteration or at function end.


ddcf1d336c Thomas Adam

gotwebd: free commit_msg0 only at the end of got_get_repo_tags

in case of a failure between when it's allocated and when it's released it might get leaked otherwise. ok and semplification stsp@


19d60ee3e1 Thomas Adam

gotwebd: plug some leaks in got_get_repo_tags

ok stsp@


f95e65a1d7 Thomas Adam

gotwebd: free age and reflist in gotweb_render_branches

ok stsp@


a42e5f4ff9 Thomas Adam

switch diff output mode from "edscript" to "plain" for diff3

getchange() in diff3.c takes any line that starts with an integer and treats it as a hunk header. It doesn't actually require ed script instructions, and traditional ed script diff output would break it. Thus, changing Got's diff3 to rely on plain diff output mode paves the way for implementing traditional ed-script style output in diff.git. Patch by Tom Jones



5ef2cc1cfe Thomas Adam

plug a leak in match_loose_object

in the loop of match_loose_object we allocate a string per directory entry that in some case it was free(3)'d before `continue' or `goto', but not always. Instead, use a more common idiom. ok stsp@


b15f45f460 Thomas Adam

sync files from diff.git 35eae7fa6b782ae1d000183ef2efc4383dfec4cd

This removes the gcc ternary if extension (includes follow-up diff.git fix for missing '\' in wrapped macro 7a38b3a33f8b124c9c01da154dfdf711d328b01d)


f530ab0e96 Thomas Adam

gotwebd: free scandir(3) result in gotweb_render_index

ok stsp@


b076498449 Thomas Adam

gotwebd: free qs->headref before overwriting it


8463025419 Thomas Adam

gotwebd: fix leak in gotweb_init_querystring in error path

if strdup fails we fail to free the querystring Found by clang' scan-build.


1510f72d86 Thomas Adam

gotwebd: add missing fcgi_printf return check

dead store found by clang' scan-build.


fb3a824076 Thomas Adam

gotwebd: fix assets URLs

In 95a4a5a1e8d0952ee0d2523dc31df7170d80e0b3 I forgot to fix the links for the favicons and the web manifest.