Commit Briefs

dff918251f Mark Jamsek

tog: populate new child view log lines when switching split

When switching a child log view from a h- to a v-split, new log lines are empty. Rather than (mis)trace height and (not) call request_log_commits(), let resize_log_view() do the math and request commits if needed to draw new lines. ok op@



c8283a6b5c Stefan Sperling

fix wrong error return in cmd_commit()


6f74883306 Stefan Sperling

comment tweak


0c41134356 Stefan Sperling

got_repo_pack_fds_close: don't close(0)

got_repo_pack_fds_close will try to close all of the GOT_PACK_NUM_TEMPFILES fds, even the ones that didn't manage to get a value from got_opentempfd(), which would result in a close(0) if we do not initialize to -1 here.


c46eda88bc Florian Obser

Correctly track if we sent more data since the last time we looked.

With the narrow scope of bytes_sent_cur it would always be zero, and we would always update progress. Found by llvm's scan-build (Dead store). OK stsp


c3821befbe Florian Obser

Prevent use-after-free of packed_refs_path in error path.

Found by llvm's scan-build. OK stsp


c9e76cc42e Florian Obser

Prevent memory leak when asprintf fails.

Found by llvm's scan-build. OK stsp


f97edf0cbc Florian Obser

Make sure got_repo_pack_fds_close() frees a malloc'ed pointer.

Found by llvm's scan-build (bad free). OK stsp


2edc2f9dc1 Florian Obser

If the first readdir() returns NULL err is uninitialized.

This can't happen in practice, but llvm's scan-build doesn't know this. OK stsp


b7ced45745 Florian Obser

We don't care about the length of the read line.

Found by llvm's scan-build (dead store). OK stsp


eff5685099 Florian Obser

Do not ignore error from got_pathlist_append.

Found by llvm's scan-build (dead store). OK stsp


a310d9c3a9 Florian Obser

Do not ignore error from format_author().

Found by llvm's scan-build (dead store). OK stsp


c9917e65d9 Florian Obser

Dot not ignore error from got_object_id_str().

Found by llvm's scan-build (dead store). OK stsp


3c29341b5d Florian Obser

path_got is unused and never assigned, no need to free it

OK stsp


538b6881e1 Florian Obser

Do not ignore I/O errors.

Found by llvm's scan-build (dead store). OK stsp


b5d22c3864 Florian Obser

Don't chug along if repo format version is unsupported.

Found by llvm's scan-build (dead store). OK stsp


fced5a6606 Christian Weisgerber

gotwebd: fix potential type mismatch between format specifier and argument

ok tracey


05f04cdf3f Mark Jamsek

tog: blame view keymap to open log of annotated line

As per stsp's TODO item: open a log view of the selected line with 'L'. helped by and ok stsp@


97f28afb98 Omar Polo

regress: add missing return in error path


8978dfde09 Stefan Sperling

document pull request workflow in got.1 man page

With permission from Jelmer Vernooij to use my pull request config for Dulwich, and Jelmer's name, as a real-life example. ok tracey, jamsek


79deadfa3f Omar Polo

typo in cat_commit

otherwise prints the author instead of the committer


2b3e670274 Mark Jamsek

tog: alias J and K to > and < keybindings for diff view

Use J and K to move to the next and previous commits, respectively, when the diff is loaded from the log or blame views. Patch by Mikhail ok stsp@


62b21d332b Omar Polo

got commit: add flag to specify the author

This adds a new flag, `got commit -A', that allows to specify the commit author but retains the "committer" (which is obtained as usual via GOT_AUTHOR, got.conf or git config.) with lots of help from and ok stsp


314c3f148b Omar Polo

TODO: remove tog author/committer toggle entry