Commit Briefs

ea4587d81c Omar Polo

add myself in the AUTHORs section

diff | patch | tree

9cb53404b6 Stefan Sperling

update cleanup -p documentation

diff | patch | tree

86f65ee665 Stefan Sperling

gotadmin cleanup can remove pack files now so update CAVEATS accordingly

diff | patch | tree

2b6cbab50e Stefan Sperling

do not try to explain implementation internals in gotadmin cleanup docs

diff | patch | tree

cbb6b806f3 Stefan Sperling

there is no 'got tag -d' command, but cleanup docs can mention fetch -X

diff | patch | tree

af386a8b5a Stefan Sperling

reorder paragraphs in gotadmin.1 cleanup section

All the special cases are now being explained last.

diff | patch | tree

1725e0b0a9 Stefan Sperling

slightly reword documentation of .keep files in gotadmin.1 for clarity

diff | patch | tree

c5058f5da6 Stefan Sperling

mention rebase/histedit -X options in addition to ref -d in gotadmin.1

diff | patch | tree

9a7c12cfb1 Omar Polo

gotadmin cleanup: remove redundant pack files

improvements and ok stsp@

diff | patch | tree

ea4ee74a61 Omar Polo

regress/cmdline: fix handling of unexpected success

Diff from James Cook, thanks!

diff | patch | tree

2f3ccc5ff6 Omar Polo

gather_on_disk_refs(): skip over bad refs

noticed since gotwebd fails when there's a ref.lock file due to a concurrent update. discussed with stsp.

diff | patch | tree

1df1761f70 Stefan Sperling

make gotd show relevant commit hashes in error message if ref-updates collide

diff | patch | tree

f8780fee7a Stefan Sperling

make gotd avoid re-writing existing ref files when a ref-update is a no-op

diff | patch | tree

4448825ab5 Omar Polo

dropping unnecessary strlen()s

ok jamsek, stsp

diff | patch | tree

39c864a48b Omar Polo

avoid strlen in for(;;)

ok jamsek, stsp

diff | patch | tree

f987c90b41 Stefan Sperling

ignore write errors to pack children while closing a repository

If the child has exited for some reason then we won't be able to send a stop message on the pipe. Ignore such errors while we are tearing a repository data structure down. The error should be harmless but can trip up gotwebd when cycling repositories out of its repo cache: gotwebd[29683]: gotweb_render_index: got-portable.git: unexpected end of file

diff | patch | tree

f4a5cef154 Omar Polo

gotwebd: set chroot path in config_init()

saves a bit fiddling around with ternary operators. sockets_run() will reset the chroot to the default since it calls again config_init(), but at that stage it's not important anymore. ok stsp@

diff | patch | tree

23c35dae29 Omar Polo

change got_get_repo_tags' limit argument to size_t

The function already carefully avoids wrapping around zero. While here add a sanity check for limit == 0, like what was previously done for got_get_repo_commits().

diff | patch | tree

a678036d5f Omar Polo

gotwebd.conf: error if chroot is the empty string

diff | patch | tree

1a0c81fb61 Omar Polo

gotwebd.conf: range-check numeric values and raise errors

diff | patch | tree

031687baf3 Omar Polo

gotwebd.conf: disallow yes/no for booleans

Supporting both "no" and "on" as valid syntax with an opposite meaning could easily result in accidental misconfiguration. Suggested by stsp, tracey agrees. Patch by Josiah Frentsos, thanks!

diff | patch | tree

d571a1762e Omar Polo

drop unused strlen; ok stsp@

diff | patch | tree

0a2fc48663 Omar Polo

gotwebd: make got_get_repo_commits take a size_t

and while here make sure 0 is rejected. requested by, improvements and ok stsp@

diff | patch | tree

f4425f95a5 Omar Polo

gotwebd: disallow 1 for max_commits_display and report range errors

ok stsp

diff | patch | tree

5144d22b0c Omar Polo

gotwebd: simplify got_get_repo_commits(): don't traverse all the commits!

In some cases (e.g. limit=1 for DIFF action) we could end up traversing all the commits instead of fetching just the one requested. Needless to say, this makes the diff page extremely slow. reported by and ok stsp@

diff | patch | tree